-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time-averaged joule heating auxkernel #2
base: main
Are you sure you want to change the base?
Conversation
a7987d3
to
b1e91f2
Compare
Hey @jvwilliams23, Do you think you could confirm this still produces the same results? Regarding the post processors, I think the temperature definitely belongs here, not sure if the power should be moved to the |
b49b0b9
to
bcdab32
Compare
Hi @nmnobre I will check this tomorrow. R.e. power post-processors; I am not sure - it is useful to check the convergence of time-averaged joule heating, and is strongly linked to how well or poorly our sims agree with Apollo. In that sense, it could fall within scope for |
Okay, sounds good, I was also just convincing myself that the green dots above should be below the blue dots, but that does seem consistent with the fact we're using implicit time stepping, so I'm happy. |
bcdab32
to
d311035
Compare
e2e7ca3
to
9d4d0c1
Compare
170606f
to
7391396
Compare
7391396
to
5e86a77
Compare
f769040
to
289fdff
Compare
fb25c16
to
bf6e0d6
Compare
bf6e0d6
to
7c1dbda
Compare
Co-authored-by: Nuno Nobre <[email protected]>
7c1dbda
to
8bc364f
Compare
Add separate timestep for EM and temperature solve in Parameters.i Co-authored-by: Nuno Nobre <[email protected]>
Co-authored-by: Josh Williams <[email protected]>
8bc364f
to
7aa4481
Compare
1f4da57
to
5e8e142
Compare
I added code for time-averaged joule heating, and made modifications to the example.
The figure below shows some test results, with
end_t_temp = ${fparse voltage_period*20}
and varyingdelta_t_temp
. The compute time results are below: