Skip to content

Add time-averaged joule heating auxkernel#2

Merged
nmnobre merged 4 commits intomainfrom
feature_timeavgjoule
Apr 8, 2025
Merged

Add time-averaged joule heating auxkernel#2
nmnobre merged 4 commits intomainfrom
feature_timeavgjoule

Conversation

@jvwilliams23
Copy link
Member

I added code for time-averaged joule heating, and made modifications to the example.

The figure below shows some test results, with end_t_temp = ${fparse voltage_period*20} and varying delta_t_temp. The compute time results are below:

  • Black line: 838 s
  • Blue dots: 616 s
  • Green dots: 75 s

pr_fig

@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from a7987d3 to b1e91f2 Compare August 19, 2024 17:40
@nmnobre nmnobre marked this pull request as ready for review August 20, 2024 09:10
@nmnobre
Copy link
Member

nmnobre commented Aug 20, 2024

Hey @jvwilliams23,

Do you think you could confirm this still produces the same results?
I refactored the code slightly, and can't see any difference, but still.

Regarding the post processors, I think the temperature definitely belongs here, not sure if the power should be moved to the viz branch, what do you reckon?

@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from b49b0b9 to bcdab32 Compare August 20, 2024 10:26
@jvwilliams23
Copy link
Member Author

Hi @nmnobre

I will check this tomorrow. R.e. power post-processors; I am not sure - it is useful to check the convergence of time-averaged joule heating, and is strongly linked to how well or poorly our sims agree with Apollo. In that sense, it could fall within scope for main.
Maybe once we have a better interpretation of optimal averaging procedure (e.g. number of cycles needed), then it could be moved to viz in future. What do you think?

@nmnobre
Copy link
Member

nmnobre commented Aug 20, 2024

Hi @nmnobre

I will check this tomorrow. R.e. power post-processors; I am not sure - it is useful to check the convergence of time-averaged joule heating, and is strongly linked to how well or poorly our sims agree with Apollo. In that sense, it could fall within scope for main. Maybe once we have a better interpretation of optimal averaging procedure (e.g. number of cycles needed), then it could be moved to viz in future. What do you think?

Okay, sounds good, let's keep it as is for now. on second thought, I think using ElementIntegralVariablePostprocessor might make more sense for P.

I was also just convincing myself that the green dots above should be below the blue dots, but that does seem consistent with the fact we're using implicit time stepping, so I'm happy.

@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from bcdab32 to d311035 Compare August 21, 2024 11:17
@nmnobre nmnobre force-pushed the main branch 4 times, most recently from e2e7ca3 to 9d4d0c1 Compare August 21, 2024 15:52
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch 2 times, most recently from 170606f to 7391396 Compare August 21, 2024 16:24
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from 7391396 to 5e86a77 Compare August 23, 2024 15:15
@nmnobre nmnobre force-pushed the main branch 5 times, most recently from f769040 to 289fdff Compare August 29, 2024 19:47
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from fb25c16 to bf6e0d6 Compare September 11, 2024 09:14
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch 3 times, most recently from 8bc364f to 7aa4481 Compare September 11, 2024 17:28
@nmnobre nmnobre force-pushed the main branch 5 times, most recently from 1f4da57 to 5e8e142 Compare September 14, 2024 11:22
@nmnobre nmnobre force-pushed the main branch 2 times, most recently from 1a84337 to b194e5b Compare April 7, 2025 23:23
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch 2 times, most recently from 5d3a986 to 952ba64 Compare April 8, 2025 09:37
@jvwilliams23
Copy link
Member Author

Why skip 5 periods?

skip_t_em            = ${fparse voltage_period*5}             # s
end_t_em             = ${fparse voltage_period*6}             # s

@nmnobre nmnobre force-pushed the feature_timeavgjoule branch 2 times, most recently from 95973e8 to cc277cd Compare April 8, 2025 09:48
@nmnobre
Copy link
Member

nmnobre commented Apr 8, 2025

Why skip 5 periods?

😆 That's just what I had in an old commit I never pushed, I've amended to only skip one now.

@nmnobre nmnobre force-pushed the feature_timeavgjoule branch 3 times, most recently from e8ec944 to 44c49b9 Compare April 8, 2025 10:20
@nmnobre nmnobre force-pushed the main branch 2 times, most recently from 577d906 to 26730ca Compare April 8, 2025 16:35
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from 44c49b9 to 9eb51d0 Compare April 8, 2025 16:39
@nmnobre nmnobre force-pushed the feature_timeavgjoule branch from 9eb51d0 to f16b056 Compare April 8, 2025 16:47
@nmnobre nmnobre merged commit 04ea9e1 into main Apr 8, 2025
@nmnobre nmnobre deleted the feature_timeavgjoule branch April 8, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants